2022-07-28 03:57:50 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Video <videogamesm12@gmail.com>
|
|
|
|
Date: Wed, 27 Jul 2022 22:30:39 -0500
|
|
|
|
Subject: [PATCH] Validate coordinates before attempting to get block entities
|
|
|
|
when handling Creative Inventory packets
|
|
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
2022-11-10 23:23:17 +00:00
|
|
|
index 4ab50df1e4c855587ef030cf3f2a1502798cb721..c7d7711be1bd17a25c98578ad68154255135facd 100644
|
2022-07-28 03:57:50 +00:00
|
|
|
--- a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
2022-10-08 21:32:38 +00:00
|
|
|
@@ -1934,6 +1934,18 @@ public class ServerGamePacketListenerImpl implements ServerPlayerConnection, Tic
|
2022-07-28 03:57:50 +00:00
|
|
|
}
|
|
|
|
// Spigot end
|
|
|
|
|
|
|
|
+ // Scissors start - Readd the following Paper code
|
|
|
|
+ // Paper start
|
|
|
|
+ private static final int SURVIVAL_PLACE_DISTANCE_SQUARED = 6 * 6;
|
|
|
|
+ private static final int CREATIVE_PLACE_DISTANCE_SQUARED = 7 * 7;
|
|
|
|
+ private boolean isOutsideOfReach(double x, double y, double z) {
|
|
|
|
+ Location eyeLoc = this.getCraftPlayer().getEyeLocation();
|
|
|
|
+ double reachDistance = org.bukkit.util.NumberConversions.square(eyeLoc.getX() - x) + org.bukkit.util.NumberConversions.square(eyeLoc.getY() - y) + org.bukkit.util.NumberConversions.square(eyeLoc.getZ() - z);
|
|
|
|
+ return reachDistance > (this.getCraftPlayer().getGameMode() == org.bukkit.GameMode.CREATIVE ? CREATIVE_PLACE_DISTANCE_SQUARED : SURVIVAL_PLACE_DISTANCE_SQUARED);
|
|
|
|
+ }
|
|
|
|
+ // Paper end
|
|
|
|
+ // Scissors end
|
|
|
|
+
|
|
|
|
@Override
|
|
|
|
public void handleUseItemOn(ServerboundUseItemOnPacket packet) {
|
|
|
|
PacketUtils.ensureRunningOnSameThread(packet, this, this.player.getLevel());
|
2022-11-10 23:23:17 +00:00
|
|
|
@@ -3451,17 +3463,24 @@ public class ServerGamePacketListenerImpl implements ServerPlayerConnection, Tic
|
2022-07-28 03:57:50 +00:00
|
|
|
if (!itemstack.isEmpty() && nbttagcompound != null && nbttagcompound.contains("x") && nbttagcompound.contains("y") && nbttagcompound.contains("z") && this.player.getBukkitEntity().hasPermission("minecraft.nbt.copy")) { // Spigot
|
|
|
|
BlockPos blockposition = BlockEntity.getPosFromTag(nbttagcompound);
|
|
|
|
|
|
|
|
- if (this.player.level.isLoaded(blockposition)) {
|
|
|
|
- // Paper start
|
|
|
|
- BlockEntity tileentity = null;
|
|
|
|
- if (this.player.distanceToSqr(blockposition.getX(), blockposition.getY(), blockposition.getZ()) < 32 * 32 && this.player.getLevel().isLoadedAndInBounds(blockposition)) {
|
|
|
|
- tileentity = this.player.level.getBlockEntity(blockposition);
|
|
|
|
- }
|
|
|
|
- // Paper end
|
|
|
|
+ if (this.player.level.isLoaded(blockposition))
|
|
|
|
+ {
|
|
|
|
+ // Scissors start - Validate coordinates and whether the player can reach them
|
|
|
|
+ if (Level.isInSpawnableBounds(blockposition) && !isOutsideOfReach(blockposition.getX(), blockposition.getY(), blockposition.getZ()))
|
|
|
|
+ {
|
|
|
|
+ BlockEntity tileentity = null;
|
|
|
|
+ if (this.player.distanceToSqr(blockposition.getX(), blockposition.getY(), blockposition.getZ()) < 32 * 32 && this.player.getLevel().isLoadedAndInBounds(blockposition))
|
|
|
|
+ {
|
|
|
|
+ tileentity = this.player.level.getBlockEntity(blockposition);
|
|
|
|
+ }
|
|
|
|
+ // Paper end
|
|
|
|
|
|
|
|
- if (tileentity != null) {
|
|
|
|
- tileentity.saveToItem(itemstack);
|
|
|
|
+ if (tileentity != null)
|
|
|
|
+ {
|
|
|
|
+ tileentity.saveToItem(itemstack);
|
|
|
|
+ }
|
|
|
|
}
|
|
|
|
+ // Scissors end
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|