2022-07-10 02:21:23 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Allink <arclicious@vivaldi.net>
|
|
|
|
Date: Sun, 10 Jul 2022 02:55:01 +0100
|
|
|
|
Subject: [PATCH] Prevent invalid container events
|
|
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
2022-07-10 06:46:35 +00:00
|
|
|
index 7c6fceb410f6b8683795a0a967dfe3305a689e26..5a8d4421c2de0680a3f4880451badcf5c4b46597 100644
|
2022-07-10 02:21:23 +00:00
|
|
|
--- a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
|
|
|
@@ -31,6 +31,8 @@ import java.util.function.UnaryOperator;
|
|
|
|
import java.util.stream.Collectors;
|
|
|
|
import java.util.stream.Stream;
|
|
|
|
import javax.annotation.Nullable;
|
|
|
|
+
|
|
|
|
+import net.kyori.adventure.text.format.NamedTextColor;
|
|
|
|
import net.minecraft.ChatFormatting;
|
|
|
|
import net.minecraft.CrashReport;
|
|
|
|
import net.minecraft.CrashReportCategory;
|
2022-07-10 06:46:35 +00:00
|
|
|
@@ -2840,6 +2842,19 @@ public class ServerGamePacketListenerImpl implements ServerPlayerConnection, Ser
|
|
|
|
public void handleContainerClick(ServerboundContainerClickPacket packet) {
|
|
|
|
PacketUtils.ensureRunningOnSameThread(packet, this, this.player.getLevel());
|
|
|
|
if (this.player.isImmobile()) return; // CraftBukkit
|
2022-07-10 02:21:23 +00:00
|
|
|
+
|
2022-07-10 06:46:35 +00:00
|
|
|
+ // Scissors start - Do not call events when the slot/button number is invalid
|
|
|
|
+ final int sentSlotNum = packet.getSlotNum();
|
|
|
|
+ if(Mth.clamp(sentSlotNum, 0, 45) != sentSlotNum)
|
|
|
|
+ {
|
|
|
|
+ this.getCraftPlayer().kick(
|
|
|
|
+ net.kyori.adventure.text.Component.text("Invalid container click slot (Hacking?)")
|
|
|
|
+ .color(NamedTextColor.RED)
|
|
|
|
+ );
|
|
|
|
+ return;
|
|
|
|
+ }
|
|
|
|
+ // Scissors end
|
|
|
|
+
|
|
|
|
this.player.resetLastActionTime();
|
|
|
|
if (this.player.containerMenu.containerId == packet.getContainerId() && this.player.containerMenu.stillValid(this.player)) { // CraftBukkit
|
|
|
|
boolean cancelled = this.player.isSpectator(); // CraftBukkit - see below if
|