From b9606fa0e3087bb9ec6ec6a2f15104839d4a89e0 Mon Sep 17 00:00:00 2001 From: speed <43330808+speedxx@users.noreply.github.com> Date: Sat, 26 Dec 2020 18:54:15 -0500 Subject: [PATCH 1/6] admin chat discord formatting (FS-59) --- .../totalfreedommod/ChatManager.java | 3 +- .../totalfreedommod/SavedFlags.java | 2 +- .../totalfreedommod/admin/Admin.java | 2 +- .../blocking/command/CommandBlockerEntry.java | 2 +- .../blocking/command/CommandBlockerRank.java | 2 +- .../command/Command_myadmin.java | 6 +- .../totalfreedommod/config/ConfigEntry.java | 2 +- .../totalfreedommod/discord/Discord.java | 2 - .../discord/DiscordToAdminChatListener.java | 93 ++++++++++++++++--- .../discord/PrivateMessageListener.java | 7 +- .../httpd/ModuleExecutable.java | 2 +- .../permissions/PermissionEntry.java | 2 +- .../totalfreedommod/player/PlayerData.java | 4 +- .../totalfreedommod/util/FSync.java | 12 +-- .../totalfreedommod/util/FUtil.java | 2 +- .../totalfreedommod/util/History.java | 2 +- 16 files changed, 107 insertions(+), 38 deletions(-) diff --git a/src/main/java/me/totalfreedom/totalfreedommod/ChatManager.java b/src/main/java/me/totalfreedom/totalfreedommod/ChatManager.java index 8d6d642d..72d947a3 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/ChatManager.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/ChatManager.java @@ -144,8 +144,7 @@ public class ChatManager extends FreedomService public ChatColor getColor(Displayable display) { - ChatColor color = display.getColor(); - return color; + return display.getColor(); } public String getColoredTag(Displayable display) diff --git a/src/main/java/me/totalfreedom/totalfreedommod/SavedFlags.java b/src/main/java/me/totalfreedom/totalfreedommod/SavedFlags.java index 8a0cd287..4fd400f1 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/SavedFlags.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/SavedFlags.java @@ -27,7 +27,7 @@ public class SavedFlags extends FreedomService { Map flags = null; - File input = new File(TotalFreedomMod.plugin().getDataFolder(), SAVED_FLAGS_FILENAME); + File input = new File(TotalFreedomMod.getPlugin().getDataFolder(), SAVED_FLAGS_FILENAME); if (input.exists()) { try diff --git a/src/main/java/me/totalfreedom/totalfreedommod/admin/Admin.java b/src/main/java/me/totalfreedom/totalfreedommod/admin/Admin.java index 151f4d5d..30b543e1 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/admin/Admin.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/admin/Admin.java @@ -140,7 +140,7 @@ public class Admin { this.active = active; - final TotalFreedomMod plugin = TotalFreedomMod.plugin(); + final TotalFreedomMod plugin = TotalFreedomMod.getPlugin(); if (!active) { diff --git a/src/main/java/me/totalfreedom/totalfreedommod/blocking/command/CommandBlockerEntry.java b/src/main/java/me/totalfreedom/totalfreedommod/blocking/command/CommandBlockerEntry.java index deb43964..8130b2f4 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/blocking/command/CommandBlockerEntry.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/blocking/command/CommandBlockerEntry.java @@ -40,7 +40,7 @@ public class CommandBlockerEntry { if (action == CommandBlockerAction.BLOCK_AND_EJECT && sender instanceof Player) { - TotalFreedomMod.plugin().ae.autoEject((Player)sender, "You used a prohibited command: " + command); + TotalFreedomMod.getPlugin().ae.autoEject((Player)sender, "You used a prohibited command: " + command); FUtil.bcastMsg(sender.getName() + " was automatically kicked for using harmful commands.", ChatColor.RED); return; } diff --git a/src/main/java/me/totalfreedom/totalfreedommod/blocking/command/CommandBlockerRank.java b/src/main/java/me/totalfreedom/totalfreedommod/blocking/command/CommandBlockerRank.java index 83e7bdf7..be0448c4 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/blocking/command/CommandBlockerRank.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/blocking/command/CommandBlockerRank.java @@ -32,7 +32,7 @@ public enum CommandBlockerRank public static CommandBlockerRank fromSender(CommandSender sender) { - Admin admin = TotalFreedomMod.plugin().al.getAdmin(sender); + Admin admin = TotalFreedomMod.getPlugin().al.getAdmin(sender); if (admin != null) { if (admin.getRank() == Rank.SENIOR_ADMIN) diff --git a/src/main/java/me/totalfreedom/totalfreedommod/command/Command_myadmin.java b/src/main/java/me/totalfreedom/totalfreedommod/command/Command_myadmin.java index b8148bc9..b88434c0 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/command/Command_myadmin.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/command/Command_myadmin.java @@ -138,6 +138,7 @@ public class Command_myadmin extends FreedomCommand return true; } + case "setacformat": case "setscformat": { String format = StringUtils.join(args, " ", 1, args.length); @@ -150,6 +151,7 @@ public class Command_myadmin extends FreedomCommand return true; } + case "clearacformat": case "clearscformat": { target.setAcFormat(null); @@ -203,8 +205,8 @@ public class Command_myadmin extends FreedomCommand return Collections.emptyList(); } - List singleArguments = Arrays.asList("clearips", "setscformat"); - List doubleArguments = Arrays.asList("clearip", "clearscformat", "syncroles"); + List singleArguments = Arrays.asList("clearips", "setscformat", "setacformat"); + List doubleArguments = Arrays.asList("clearip", "clearscformat", "clearacformat", "syncroles"); if (args.length == 1) { List options = new ArrayList<>(); diff --git a/src/main/java/me/totalfreedom/totalfreedommod/config/ConfigEntry.java b/src/main/java/me/totalfreedom/totalfreedommod/config/ConfigEntry.java index 926aac8f..e597b9c6 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/config/ConfigEntry.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/config/ConfigEntry.java @@ -239,7 +239,7 @@ public enum ConfigEntry private MainConfig getConfig() { - return TotalFreedomMod.plugin().config; + return TotalFreedomMod.getPlugin().config; } public static ConfigEntry findConfigEntry(String name) diff --git a/src/main/java/me/totalfreedom/totalfreedommod/discord/Discord.java b/src/main/java/me/totalfreedom/totalfreedommod/discord/Discord.java index bf62f31a..37d5464b 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/discord/Discord.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/discord/Discord.java @@ -167,7 +167,6 @@ public class Discord extends FreedomService public User getUser(String id) { Guild guild = bot.getGuildById(ConfigEntry.DISCORD_SERVER_ID.getString()); - if (guild == null) { FLog.severe("Either the bot is not in the Discord server or it doesn't exist. Check the server ID."); @@ -175,7 +174,6 @@ public class Discord extends FreedomService } Member member = guild.getMemberById(id); - if (member == null) { return null; diff --git a/src/main/java/me/totalfreedom/totalfreedommod/discord/DiscordToAdminChatListener.java b/src/main/java/me/totalfreedom/totalfreedommod/discord/DiscordToAdminChatListener.java index 169b9d43..01f5c81a 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/discord/DiscordToAdminChatListener.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/discord/DiscordToAdminChatListener.java @@ -1,8 +1,14 @@ package me.totalfreedom.totalfreedommod.discord; import me.totalfreedom.totalfreedommod.TotalFreedomMod; +import me.totalfreedom.totalfreedommod.admin.Admin; import me.totalfreedom.totalfreedommod.config.ConfigEntry; +import me.totalfreedom.totalfreedommod.rank.Displayable; +import me.totalfreedom.totalfreedommod.rank.Rank; +import me.totalfreedom.totalfreedommod.rank.Title; import me.totalfreedom.totalfreedommod.util.FLog; +import me.totalfreedom.totalfreedommod.util.FUtil; +import net.dv8tion.jda.api.entities.Guild; import net.dv8tion.jda.api.entities.Member; import net.dv8tion.jda.api.entities.Message; import net.dv8tion.jda.api.events.message.MessageReceivedEvent; @@ -23,23 +29,39 @@ public class DiscordToAdminChatListener extends ListenerAdapter String chat_channel_id = ConfigEntry.DISCORD_ADMINCHAT_CHANNEL_ID.getString(); if (event.getMember() != null && !chat_channel_id.isEmpty() && event.getChannel().getId().equals(chat_channel_id)) { - if (!event.getAuthor().getId().equals(Discord.bot.getSelfUser().getId())) + if (!event.getAuthor().getId().equals(event.getJDA().getSelfUser().getId())) { Member member = event.getMember(); String tag = dtml.getDisplay(member); - StringBuilder message = new StringBuilder(ChatColor.DARK_GRAY + "[" + ChatColor.DARK_AQUA + "ADMIN" + ChatColor.DARK_GRAY + "]"); + StringBuilder message = new StringBuilder(ChatColor.DARK_GRAY + "[" + ChatColor.DARK_AQUA + "Discord" + ChatColor.DARK_GRAY + "] " + ChatColor.RESET); Message msg = event.getMessage(); - if (tag != null) + for (Player player : Bukkit.getOnlinePlayers()) { - message.append(" ").append(tag); + if (TotalFreedomMod.getPlugin().al.isAdmin(player)) + { + Admin admin = TotalFreedomMod.getPlugin().al.getAdmin(player); + String format = admin.getAcFormat(); + if (format != null) + { + Displayable display = TotalFreedomMod.getPlugin().rm.getDisplay(player); + net.md_5.bungee.api.ChatColor color = getColor(display); + String m = format.replace("%name%", member.getEffectiveName()) + .replace("%rank%", getDisplay(member)) + .replace("%rankcolor%", color.toString()) + .replace("%msg%", FUtil.colorize(msg.getContentDisplay())); + message.append(FUtil.colorize(m)); + } + else + { + String m = ChatColor.DARK_RED + member.getEffectiveName() + " " + + ChatColor.DARK_GRAY + tag + ChatColor.DARK_GRAY + + ChatColor.WHITE + ": " + ChatColor.GOLD + FUtil.colorize(msg.getContentDisplay()); + message.append(m); + } + } } - message.append(" " + ChatColor.RED).append(ChatColor.stripColor(member.getEffectiveName())).append(ChatColor.DARK_GRAY).append(":").append(ChatColor.RESET); + ComponentBuilder builder = new ComponentBuilder(message.toString()); - if (!msg.getContentDisplay().isEmpty()) - { - builder.append(" ").append(ChatColor.stripColor(msg.getContentDisplay())); - message.append(" ").append(ChatColor.stripColor(msg.getContentDisplay())); // for logging - } if (!msg.getAttachments().isEmpty()) { for (Message.Attachment attachment : msg.getAttachments()) @@ -48,13 +70,14 @@ public class DiscordToAdminChatListener extends ListenerAdapter { continue; } - builder.append(" "); + TextComponent text = new TextComponent(ChatColor.YELLOW + "[Media]"); text.setClickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, attachment.getUrl())); builder.append(text); - message.append(" [Media]"); // for logging + message.append("[Media]"); // for logging } } + for (Player player : Bukkit.getOnlinePlayers()) { if (TotalFreedomMod.getPlugin().al.isAdmin(player)) @@ -66,4 +89,50 @@ public class DiscordToAdminChatListener extends ListenerAdapter } } } + + public static net.md_5.bungee.api.ChatColor getColor(Displayable display) + { + return display.getColor(); + } + + // Needed to display tags in custom AC messages + public String getDisplay(Member member) + { + Guild server = Discord.bot.getGuildById(ConfigEntry.DISCORD_SERVER_ID.getString()); + // Server Owner + if (member.getRoles().contains(server.getRoleById(ConfigEntry.DISCORD_SERVER_OWNER_ROLE_ID.getString()))) + { + return Title.OWNER.getAbbr(); + } + // Developers + else if (member.getRoles().contains(server.getRoleById(ConfigEntry.DISCORD_DEVELOPER_ROLE_ID.getString()))) + { + return Title.DEVELOPER.getAbbr(); + } + // Executives + else if (member.getRoles().contains(server.getRoleById(ConfigEntry.DISCORD_EXECUTIVE_ROLE_ID.getString()))) + { + return Title.EXECUTIVE.getAbbr(); + } + // Senior Admins + else if (member.getRoles().contains(server.getRoleById(ConfigEntry.DISCORD_SENIOR_ADMIN_ROLE_ID.getString()))) + { + return Rank.SENIOR_ADMIN.getAbbr(); + } + // Admins + else if (member.getRoles().contains(server.getRoleById(ConfigEntry.DISCORD_NEW_ADMIN_ROLE_ID.getString()))) + { + return Rank.ADMIN.getAbbr(); + } + // Master Builders + else if (member.getRoles().contains(server.getRoleById(ConfigEntry.DISCORD_MASTER_BUILDER_ROLE_ID.getString()))) + { + return Title.MASTER_BUILDER.getAbbr(); + } + // OP, returning null breaks? + else + { + return Rank.OP.getAbbr(); + } + } } \ No newline at end of file diff --git a/src/main/java/me/totalfreedom/totalfreedommod/discord/PrivateMessageListener.java b/src/main/java/me/totalfreedom/totalfreedommod/discord/PrivateMessageListener.java index 9c82a81e..cd964ac4 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/discord/PrivateMessageListener.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/discord/PrivateMessageListener.java @@ -10,7 +10,7 @@ public class PrivateMessageListener extends ListenerAdapter { public void onPrivateMessageReceived(PrivateMessageReceivedEvent event) { - if (!event.getAuthor().getId().equals(Discord.bot.getSelfUser().getId())) + if (!event.getAuthor().getId().equals(event.getJDA().getSelfUser().getId())) { // Handle link code if (event.getMessage().getContentRaw().matches("[0-9][0-9][0-9][0-9][0-9]")) @@ -24,12 +24,13 @@ public class PrivateMessageListener extends ListenerAdapter player.setDiscordID(event.getMessage().getAuthor().getId()); player.setVerification(true); - Admin admin = TotalFreedomMod.plugin().al.getEntryByName(name); + Admin admin = TotalFreedomMod.getPlugin().al.getEntryByName(name); if (admin != null) { Discord.syncRoles(admin, player.getDiscordID()); } - TotalFreedomMod.plugin().pl.save(player); + + TotalFreedomMod.getPlugin().pl.save(player); Discord.LINK_CODES.remove(code); } else diff --git a/src/main/java/me/totalfreedom/totalfreedommod/httpd/ModuleExecutable.java b/src/main/java/me/totalfreedom/totalfreedommod/httpd/ModuleExecutable.java index c008afdd..f0bd63d5 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/httpd/ModuleExecutable.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/httpd/ModuleExecutable.java @@ -29,7 +29,7 @@ public abstract class ModuleExecutable } // Sync to server thread - return Bukkit.getScheduler().callSyncMethod(TotalFreedomMod.plugin(), new Callable() + return Bukkit.getScheduler().callSyncMethod(TotalFreedomMod.getPlugin(), new Callable() { @Override public NanoHTTPD.Response call() throws Exception diff --git a/src/main/java/me/totalfreedom/totalfreedommod/permissions/PermissionEntry.java b/src/main/java/me/totalfreedom/totalfreedommod/permissions/PermissionEntry.java index eaedc006..08b16351 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/permissions/PermissionEntry.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/permissions/PermissionEntry.java @@ -36,6 +36,6 @@ public enum PermissionEntry private PermissionConfig getConfig() { - return TotalFreedomMod.plugin().permissions; + return TotalFreedomMod.getPlugin().permissions; } } diff --git a/src/main/java/me/totalfreedom/totalfreedommod/player/PlayerData.java b/src/main/java/me/totalfreedom/totalfreedommod/player/PlayerData.java index f780d7ac..deae4217 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/player/PlayerData.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/player/PlayerData.java @@ -86,12 +86,12 @@ public class PlayerData if (masterBuilder && !verification) { verification = true; - TotalFreedomMod.plugin().pl.save(this); + TotalFreedomMod.getPlugin().pl.save(this); } else if (!masterBuilder && discordID == null && verification) { this.verification = false; - TotalFreedomMod.plugin().pl.save(this); + TotalFreedomMod.getPlugin().pl.save(this); } } diff --git a/src/main/java/me/totalfreedom/totalfreedommod/util/FSync.java b/src/main/java/me/totalfreedom/totalfreedommod/util/FSync.java index d1e39cad..191e0feb 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/util/FSync.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/util/FSync.java @@ -11,7 +11,7 @@ public class FSync public static void playerMsg(final Player player, final String message) { - final TotalFreedomMod plugin = TotalFreedomMod.plugin(); + final TotalFreedomMod plugin = TotalFreedomMod.getPlugin(); new BukkitRunnable() { @@ -26,7 +26,7 @@ public class FSync public static void playerMsg(final CommandSender sender, final String message) { - final TotalFreedomMod plugin = TotalFreedomMod.plugin(); + final TotalFreedomMod plugin = TotalFreedomMod.getPlugin(); new BukkitRunnable() { @@ -41,7 +41,7 @@ public class FSync public static void playerKick(final Player player, final String reason) { - final TotalFreedomMod plugin = TotalFreedomMod.plugin(); + final TotalFreedomMod plugin = TotalFreedomMod.getPlugin(); new BukkitRunnable() { @@ -56,7 +56,7 @@ public class FSync public static void adminChatMessage(final CommandSender sender, final String message) { - final TotalFreedomMod plugin = TotalFreedomMod.plugin(); + final TotalFreedomMod plugin = TotalFreedomMod.getPlugin(); new BukkitRunnable() { @@ -71,7 +71,7 @@ public class FSync public static void autoEject(final Player player, final String kickMessage) { - final TotalFreedomMod plugin = TotalFreedomMod.plugin(); + final TotalFreedomMod plugin = TotalFreedomMod.getPlugin(); new BukkitRunnable() { @@ -86,7 +86,7 @@ public class FSync public static void bcastMsg(final String message, final ChatColor color) { - final TotalFreedomMod plugin = TotalFreedomMod.plugin(); + final TotalFreedomMod plugin = TotalFreedomMod.getPlugin(); new BukkitRunnable() { diff --git a/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java b/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java index ac30c3a9..d0e375ce 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java @@ -163,7 +163,7 @@ public class FUtil List names = new ArrayList<>(); for (Player player : Bukkit.getOnlinePlayers()) { - if (!TotalFreedomMod.plugin().al.isVanished(player.getName())) + if (!TotalFreedomMod.getPlugin().al.isVanished(player.getName())) { names.add(player.getName()); } diff --git a/src/main/java/me/totalfreedom/totalfreedommod/util/History.java b/src/main/java/me/totalfreedom/totalfreedommod/util/History.java index 42b1a4aa..efceb81d 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/util/History.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/util/History.java @@ -64,7 +64,7 @@ public class History FSync.playerMsg(sender, ChatColor.RED + "Player not found!"); } } - }.runTaskAsynchronously(TotalFreedomMod.plugin()); + }.runTaskAsynchronously(TotalFreedomMod.getPlugin()); } private static void printHistory(CommandSender sender, FName[] oldNames) From 9d131f0f24c877da93a0c6b4e07c08130bb83477 Mon Sep 17 00:00:00 2001 From: speed <43330808+speedxx@users.noreply.github.com> Date: Sat, 26 Dec 2020 19:11:15 -0500 Subject: [PATCH 2/6] ok codacy --- .../discord/DiscordToAdminChatListener.java | 103 +++++++++--------- 1 file changed, 50 insertions(+), 53 deletions(-) diff --git a/src/main/java/me/totalfreedom/totalfreedommod/discord/DiscordToAdminChatListener.java b/src/main/java/me/totalfreedom/totalfreedommod/discord/DiscordToAdminChatListener.java index 01f5c81a..134810f1 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/discord/DiscordToAdminChatListener.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/discord/DiscordToAdminChatListener.java @@ -27,66 +27,63 @@ public class DiscordToAdminChatListener extends ListenerAdapter public void onMessageReceived(MessageReceivedEvent event) { String chat_channel_id = ConfigEntry.DISCORD_ADMINCHAT_CHANNEL_ID.getString(); - if (event.getMember() != null && !chat_channel_id.isEmpty() && event.getChannel().getId().equals(chat_channel_id)) + if (event.getMember() != null && !chat_channel_id.isEmpty() && event.getChannel().getId().equals(chat_channel_id) && !event.getAuthor().getId().equals(event.getJDA().getSelfUser().getId())) { - if (!event.getAuthor().getId().equals(event.getJDA().getSelfUser().getId())) + Member member = event.getMember(); + String tag = dtml.getDisplay(member); + StringBuilder message = new StringBuilder(ChatColor.DARK_GRAY + "[" + ChatColor.DARK_AQUA + "Discord" + ChatColor.DARK_GRAY + "] " + ChatColor.RESET); + Message msg = event.getMessage(); + for (Player player : Bukkit.getOnlinePlayers()) { - Member member = event.getMember(); - String tag = dtml.getDisplay(member); - StringBuilder message = new StringBuilder(ChatColor.DARK_GRAY + "[" + ChatColor.DARK_AQUA + "Discord" + ChatColor.DARK_GRAY + "] " + ChatColor.RESET); - Message msg = event.getMessage(); - for (Player player : Bukkit.getOnlinePlayers()) + if (TotalFreedomMod.getPlugin().al.isAdmin(player)) { - if (TotalFreedomMod.getPlugin().al.isAdmin(player)) + Admin admin = TotalFreedomMod.getPlugin().al.getAdmin(player); + String format = admin.getAcFormat(); + if (format != null) { - Admin admin = TotalFreedomMod.getPlugin().al.getAdmin(player); - String format = admin.getAcFormat(); - if (format != null) - { - Displayable display = TotalFreedomMod.getPlugin().rm.getDisplay(player); - net.md_5.bungee.api.ChatColor color = getColor(display); - String m = format.replace("%name%", member.getEffectiveName()) - .replace("%rank%", getDisplay(member)) - .replace("%rankcolor%", color.toString()) - .replace("%msg%", FUtil.colorize(msg.getContentDisplay())); - message.append(FUtil.colorize(m)); - } - else - { - String m = ChatColor.DARK_RED + member.getEffectiveName() + " " - + ChatColor.DARK_GRAY + tag + ChatColor.DARK_GRAY - + ChatColor.WHITE + ": " + ChatColor.GOLD + FUtil.colorize(msg.getContentDisplay()); - message.append(m); - } + Displayable display = TotalFreedomMod.getPlugin().rm.getDisplay(player); + net.md_5.bungee.api.ChatColor color = getColor(display); + String m = format.replace("%name%", member.getEffectiveName()) + .replace("%rank%", getDisplay(member)) + .replace("%rankcolor%", color.toString()) + .replace("%msg%", FUtil.colorize(msg.getContentDisplay())); + message.append(FUtil.colorize(m)); + } + else + { + String m = ChatColor.DARK_RED + member.getEffectiveName() + " " + + ChatColor.DARK_GRAY + tag + ChatColor.DARK_GRAY + + ChatColor.WHITE + ": " + ChatColor.GOLD + FUtil.colorize(msg.getContentDisplay()); + message.append(m); } } - - ComponentBuilder builder = new ComponentBuilder(message.toString()); - if (!msg.getAttachments().isEmpty()) - { - for (Message.Attachment attachment : msg.getAttachments()) - { - if (attachment.getUrl() == null) - { - continue; - } - - TextComponent text = new TextComponent(ChatColor.YELLOW + "[Media]"); - text.setClickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, attachment.getUrl())); - builder.append(text); - message.append("[Media]"); // for logging - } - } - - for (Player player : Bukkit.getOnlinePlayers()) - { - if (TotalFreedomMod.getPlugin().al.isAdmin(player)) - { - player.spigot().sendMessage(builder.create()); - } - } - FLog.info(message.toString()); } + + ComponentBuilder builder = new ComponentBuilder(message.toString()); + if (!msg.getAttachments().isEmpty()) + { + for (Message.Attachment attachment : msg.getAttachments()) + { + if (attachment.getUrl() == null) + { + continue; + } + + TextComponent text = new TextComponent(ChatColor.YELLOW + "[Media]"); + text.setClickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, attachment.getUrl())); + builder.append(text); + message.append("[Media]"); // for logging + } + } + + for (Player player : Bukkit.getOnlinePlayers()) + { + if (TotalFreedomMod.getPlugin().al.isAdmin(player)) + { + player.spigot().sendMessage(builder.create()); + } + } + FLog.info(message.toString()); } } From bc37ed53414b5d39f1c07825ef4867df05136dcb Mon Sep 17 00:00:00 2001 From: Elmon11 Date: Sun, 3 Jan 2021 19:04:23 +0100 Subject: [PATCH 3/6] Fix developer title not showing up on Offline mode servers --- .../java/me/totalfreedom/totalfreedommod/util/FUtil.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java b/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java index d0e375ce..33cf91c6 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java @@ -140,7 +140,11 @@ public class FUtil public static boolean isDeveloper(Player player) { - return DEVELOPERS.contains(player.getUniqueId().toString()); + if (getOnlineMode()) { + return DEVELOPERS.contains(player.getUniqueId().toString()); + } else { + return DEVELOPERS.contains(player.getDisplayName()); + } } public static boolean inDeveloperMode() From a3cccc7ac005eb9e7e47918877594b1162c78aae Mon Sep 17 00:00:00 2001 From: Elmon11 Date: Sun, 3 Jan 2021 19:16:41 +0100 Subject: [PATCH 4/6] Update FUtil.java --- .../me/totalfreedom/totalfreedommod/util/FUtil.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java b/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java index 33cf91c6..9dd7f4a6 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java @@ -140,13 +140,15 @@ public class FUtil public static boolean isDeveloper(Player player) { - if (getOnlineMode()) { + if (Bukkit.getOnlineMode()) + { return DEVELOPERS.contains(player.getUniqueId().toString()); - } else { - return DEVELOPERS.contains(player.getDisplayName()); + } + else + { + return DEVELOPERS.contains(player.getName()); } } - public static boolean inDeveloperMode() { return ConfigEntry.DEVELOPER_MODE.getBoolean(); From 7afa80c89f2e69529a31b3d561429e549344556f Mon Sep 17 00:00:00 2001 From: Elmon11 Date: Sun, 3 Jan 2021 19:18:14 +0100 Subject: [PATCH 5/6] Update FUtil.java --- src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java b/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java index 9dd7f4a6..70efc92c 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java @@ -149,6 +149,7 @@ public class FUtil return DEVELOPERS.contains(player.getName()); } } + public static boolean inDeveloperMode() { return ConfigEntry.DEVELOPER_MODE.getBoolean(); From e32c2eed15f0c6ff9283b5e018c7085d29f7efa5 Mon Sep 17 00:00:00 2001 From: Elmon11 Date: Sun, 3 Jan 2021 19:23:10 +0100 Subject: [PATCH 6/6] Update FUtil.java --- src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java b/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java index 70efc92c..844f2c27 100644 --- a/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java +++ b/src/main/java/me/totalfreedom/totalfreedommod/util/FUtil.java @@ -146,7 +146,7 @@ public class FUtil } else { - return DEVELOPERS.contains(player.getName()); + return DEVELOPER_NAMES.contains(player.getName()); } }