AtlasMediaGroup/TotalFreedomMod
1
0
Fork 0
mirror of https://github.com/AtlasMediaGroup/TotalFreedomMod.git synced 2025-06-29 19:46:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes for Codacy;

Browse Source 
These fixes are designed to satisfy codacy.

However, codacy reports a NPath Complexity of 649, whereas the current, recommended, and standardized threshold is 200.

This is caused by FreedomCommand#execute(CommandSender, String, String[]);
This commit is contained in:
Paldiu
2020-12-25 15:35:33 -05:00
parent 361aa4ee04
commit 97edce0a67
7 changed files with 22 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/main/java/me/totalfreedom/totalfreedommod/fun/ItemFun.java
View File

@ -324,14 +324,13 @@ public class ItemFun extends FreedomService
{
arrow = (Arrow)entity;
}
if (arrow != null && (arrow.getShooter() instanceof Player))
//Redundant Player cast is required to avoid suspicious method calls.
if (arrow != null
&& (arrow.getShooter() instanceof Player)
&& explosivePlayers.contains((Player)arrow.getShooter()))
{
//Redundant Player cast is required to avoid suspicious method calls.
if (explosivePlayers.contains(arrow.getShooter()))
{
Objects.requireNonNull(arrow.getLocation().getWorld()).createExplosion(arrow.getLocation().getX(), arrow.getLocation().getY(), arrow.getLocation().getZ(), ConfigEntry.EXPLOSIVE_RADIUS.getDouble().floatValue(), false, ConfigEntry.ALLOW_EXPLOSIONS.getBoolean());
arrow.remove();
}
Objects.requireNonNull(arrow.getLocation().getWorld()).createExplosion(arrow.getLocation().getX(), arrow.getLocation().getY(), arrow.getLocation().getZ(), ConfigEntry.EXPLOSIVE_RADIUS.getDouble().floatValue(), false, ConfigEntry.ALLOW_EXPLOSIONS.getBoolean());
arrow.remove();
}
if (entity instanceof Fireball)