Remove double storage

It is unnecessary as the information is already stored in a map (Username, IPs)
This commit is contained in:
Nathan Curran 2021-03-08 11:34:48 +11:00
parent 5b577fae07
commit 9eca9ac5b2
No known key found for this signature in database
GPG Key ID: B3A964B30C2E56B8
3 changed files with 7 additions and 18 deletions

View File

@ -22,8 +22,7 @@ import org.bukkit.entity.Player;
public class AdminList extends FreedomService public class AdminList extends FreedomService
{ {
public static final List<String> vanished = new ArrayList<>(); public static final List<String> vanished = new ArrayList<>();
public final List<String> verifiedNoAdmin = new ArrayList<>(); public final Map<String, List<String>> verifiedNoAdmin = Maps.newHashMap();
public final Map<String, List<String>> verifiedNoAdminIps = Maps.newHashMap();
private final Set<Admin> allAdmins = Sets.newHashSet(); // Includes disabled admins private final Set<Admin> allAdmins = Sets.newHashSet(); // Includes disabled admins
// Only active admins below // Only active admins below
private final Set<Admin> activeAdmins = Sets.newHashSet(); private final Set<Admin> activeAdmins = Sets.newHashSet();
@ -240,7 +239,7 @@ public class AdminList extends FreedomService
public boolean isVerifiedAdmin(Player player) public boolean isVerifiedAdmin(Player player)
{ {
return verifiedNoAdmin.contains(player.getName()) || verifiedNoAdminIps.containsKey(player.getName()) && verifiedNoAdminIps.get(player.getName()).contains(FUtil.getIp(player)); return verifiedNoAdmin.containsKey(player.getName()) && verifiedNoAdmin.get(player.getName()).contains(FUtil.getIp(player));
} }
public boolean isIdentityMatched(Player player) public boolean isIdentityMatched(Player player)
@ -403,13 +402,8 @@ public class AdminList extends FreedomService
return ipTable; return ipTable;
} }
public List<String> getVerifiedNoAdmin() public Map<String, List<String>> getVerifiedNoAdmin()
{ {
return verifiedNoAdmin; return verifiedNoAdmin;
} }
public Map<String, List<String>> getVerifiedNoAdminIps()
{
return verifiedNoAdminIps;
}
} }

View File

@ -220,7 +220,6 @@ public class Command_saconfig extends FreedomCommand
if (plugin.al.isVerifiedAdmin(player)) if (plugin.al.isVerifiedAdmin(player))
{ {
plugin.al.verifiedNoAdmin.remove(player.getName()); plugin.al.verifiedNoAdmin.remove(player.getName());
plugin.al.verifiedNoAdminIps.remove(player.getName());
} }
plugin.al.save(admin); plugin.al.save(admin);

View File

@ -34,25 +34,21 @@ public class Command_verifynoadmin extends FreedomCommand
if (plugin.al.isAdminImpostor(player)) if (plugin.al.isAdminImpostor(player))
{ {
if (!plugin.al.verifiedNoAdmin.contains(player.getName()))
{
plugin.al.verifiedNoAdmin.add(player.getName());
}
String ip = FUtil.getIp(player); String ip = FUtil.getIp(player);
if (!plugin.al.verifiedNoAdminIps.containsKey(player.getName())) if (!plugin.al.verifiedNoAdmin.containsKey(player.getName()))
{ {
List<String> ips = new ArrayList<>(); List<String> ips = new ArrayList<>();
ips.add(ip); ips.add(ip);
plugin.al.verifiedNoAdminIps.put(player.getName(), ips); plugin.al.verifiedNoAdmin.put(player.getName(), ips);
} }
else else
{ {
List<String> ips = plugin.al.verifiedNoAdminIps.get(player.getName()); List<String> ips = plugin.al.verifiedNoAdmin.get(player.getName());
if (!ips.contains(ip)) if (!ips.contains(ip))
{ {
ips.add(ip); ips.add(ip);
plugin.al.verifiedNoAdmin.remove(player.getName()); plugin.al.verifiedNoAdmin.remove(player.getName());
plugin.al.verifiedNoAdminIps.put(player.getName(), ips); plugin.al.verifiedNoAdmin.put(player.getName(), ips);
} }
} }
plugin.rm.updateDisplay(player); plugin.rm.updateDisplay(player);