These fixes are designed to satisfy codacy.
However, codacy reports a NPath Complexity of 649, whereas the current, recommended, and standardized threshold is 200.
This is caused by FreedomCommand#execute(CommandSender, String, String[]);
Lombok implementation removal.
I have also gone through and replaced things with inline methods and variables, lambdas, and simplified loops down, removed unnecessary guard clauses, and overall cleaned up every single class. This took a long time, please do remember to follow proper naming conventions, don't include unnecessary guard clauses, follow exception rules and comment rules, and please PLEASE remember to use the DIAMOND OPERATOR rather than just inferring RAW TYPES!!!
Thank you!!
* rename everything containing staff back to admin (as requested by ryan i've renamed commands like slconfig to saconfig but left "slconfig" as an alias)
* format almost every file correctly
* a few other improvements
- fix tossmob not working, sorta revamp it (#259)
- make tossmob and a few other config things toggleable with /toggle (note mp44 and landmines still don't work, i'll probably try and fix those too)
- replace if else statements with switch and catch (yandere dev code type beat)
- Added Reddit flair sync
- Removed magical saddle because the stacking potato does the same thing
- Some internal improvements
- Fixed bug where if a service throws an error while starting or stopping it breaks the entire plugin
- Ignore totalfreedom.iml (people who clone from Git get this instead of TotalFreedomMod)
- Essentials check before running /denick
- Revise grammar in /invis
- WorldEdit check for /setl (since W/E is no longer a required dependency)
- WorldEdit check for /gtfo
- WorldEdit check for /unban
- Refactor -> LibsDisguiseBridge: isPluginEnabled -> isEnabled
- Remove unneccesary ChatColor in /wiperegions
- Use BlockData in Trailer
- Revise /wiewarps grammar
- Clean up /commandlist
- /ov now displays proper unknown command message
- /toggle doesnt check for case
- Trailer will now check if CoreProtect is enabled before trying to log
- Temporarily disable master builder world restrictions, causing spam in console everytime a command is one
Version 5.0
This TotalFreedomMod release implements many changes. Most notably, the
internals have been completely revamped. TotalFreedomMod now relies on the
Aero library for core mechanics such as command handling and services.
Another important change is the UUID system. In TotalFreedomMod Electrum,
it has been completely removed. The core reason for this is that the
system as a whole was very bugged. Additionally, it did not solve the
primary reason for its conception: preserving player data when the player
changes their username. This is because TotalFreedomMod servers usually
run in offline-mode. This meaning that some of the players joining do not
have a registerd Mojang UUID whatsoever. All in all, the UUID system was
buggy, and it did not fix the reason it was implemented, so it has been
completely removed. The admin list and the ban list now use usernames and
IPs again.
Lastly, many smaller changes have been implemented. Due to the amount of
changes, they have not been named individualy. Please refer to the issues
below for more details.
Fixes#342Fixes#350Fixes#380Fixes#684Fixes#704Fixes#716Fixes#735Fixes#745Fixes#784Fixes#765Fixes#791Fixes#805Fixes#826Fixes#883Fixes#1524Fixes#1534Fixes#1536Fixes#1538Fixes#1545Fixes#1546Fixes#1568Fixes#1627Resolves#403Resolves#435Resolves#597Resolves#603Resolves#628Resolves#690Resolves#708Resolves#747Resolves#748Resolves#749Resolves#764Resolves#767Resolves#782Resolves#809Resolves#803Resolves#811Resolves#813Resolves#830Resolves#848Resolves#856Resolves#876Resolves#908Resolves#992Resolves#1018Resolves#1432Resolves#1446Resolves#1494Resolves#1501Resolves#1526Resolves#1540Resolves#1550Resolves#1560Resolves#1561Resolves#1578Resolves#1613
Refractoring
Reworked /saconfig
Reworked part of the command system
Removed unused config sections
Refractored part of the config
Fixed bugs with admin list
Actually allow CONSOLE to have senior perms