Compare commits

...

8 Commits

Author SHA1 Message Date
13e04475f0 FS-326 & quick formatting fix
The formatting of DiscordToMinecraft was adjusted in addition to make it look nicer
2021-07-29 17:06:31 -06:00
adc7b4a754 FS-333
According to Intellij, `bukkitTelnet instanceof BukkitTelnet` can replace the nullcheck. If this is not the case, then I apologize profoundly for my IDE's mistakes (again)
2021-07-29 05:58:14 -06:00
40498c03f4 FS-334
If Codacy complains about Line 365 being potentially combinable with Line 363, please kindly tell it to fuck off
2021-07-29 05:54:00 -06:00
cc9c07d498 FS-335 2021-07-29 05:49:37 -06:00
5fa3f9f26a FS-337
I hate Codacy
2021-07-29 05:48:11 -06:00
a79b2cbe0f FS-338 2021-07-29 05:45:21 -06:00
6c8d1934e7 FS-313 2021-07-29 05:38:30 -06:00
a1de7ac9ff FS-314 2021-07-29 05:35:28 -06:00
8 changed files with 131 additions and 147 deletions

View File

@ -46,7 +46,7 @@ public class SavedFlags extends FreedomService
return flags; return flags;
} }
public boolean getSavedFlag(String flag) throws Exception public boolean getSavedFlag(String flag) throws IllegalStateException
{ {
Boolean flagValue = null; Boolean flagValue = null;
@ -66,7 +66,7 @@ public class SavedFlags extends FreedomService
} }
else else
{ {
throw new Exception(); throw new IllegalStateException("Attempt to get non-existent flag " + flag);
} }
} }

View File

@ -146,15 +146,12 @@ public class EventBlocker extends FreedomService
if (ConfigEntry.ENABLE_PET_PROTECT.getBoolean()) if (ConfigEntry.ENABLE_PET_PROTECT.getBoolean())
{ {
Entity entity = event.getEntity(); Entity entity = event.getEntity();
if (entity instanceof Tameable) if (entity instanceof Tameable && ((Tameable) entity).isTamed())
{
if (((Tameable)entity).isTamed())
{ {
event.setCancelled(true); event.setCancelled(true);
} }
} }
} }
}
@EventHandler(priority = EventPriority.NORMAL) @EventHandler(priority = EventPriority.NORMAL)
public void onPlayerDropItem(PlayerDropItemEvent event) public void onPlayerDropItem(PlayerDropItemEvent event)

View File

@ -101,12 +101,9 @@ public class BukkitTelnetBridge extends FreedomService
try try
{ {
final Plugin bukkitTelnet = server.getPluginManager().getPlugin("BukkitTelnet"); final Plugin bukkitTelnet = server.getPluginManager().getPlugin("BukkitTelnet");
if (bukkitTelnet != null)
{
if (bukkitTelnet instanceof BukkitTelnet) if (bukkitTelnet instanceof BukkitTelnet)
{ {
bukkitTelnetPlugin = (BukkitTelnet)bukkitTelnet; bukkitTelnetPlugin = (BukkitTelnet) bukkitTelnet;
}
} }
} }
catch (Exception ex) catch (Exception ex)

View File

@ -362,9 +362,7 @@ public class CoreProtectBridge extends FreedomService
} }
else if (event.getAction() == Action.RIGHT_CLICK_BLOCK) else if (event.getAction() == Action.RIGHT_CLICK_BLOCK)
{ {
if (block != null) if (block != null && data.hasInspection())
{
if (data.hasInspection())
{ {
BlockState blockState = block.getRelative(event.getBlockFace()).getState(); BlockState blockState = block.getRelative(event.getBlockFace()).getState();
Block placedBlock = blockState.getBlock(); Block placedBlock = blockState.getBlock();
@ -453,5 +451,4 @@ public class CoreProtectBridge extends FreedomService
} }
} }
} }
}
} }

View File

@ -30,15 +30,12 @@ public class TFGuildsBridge extends FreedomService
try try
{ {
final Plugin tfGuilds = server.getPluginManager().getPlugin("TFGuilds"); final Plugin tfGuilds = server.getPluginManager().getPlugin("TFGuilds");
if (tfGuilds != null && tfGuilds.isEnabled()) if (tfGuilds != null && tfGuilds.isEnabled() && tfGuilds instanceof TFGuilds)
{
if (tfGuilds instanceof TFGuilds)
{ {
enabled = true; enabled = true;
return true; return true;
} }
} }
}
catch (NoClassDefFoundError ex) catch (NoClassDefFoundError ex)
{ {
return false; return false;

View File

@ -32,10 +32,9 @@ public class Command_deop extends FreedomCommand
final List<String> matchedPlayerNames = new ArrayList<>(); final List<String> matchedPlayerNames = new ArrayList<>();
for (Player player : server.getOnlinePlayers()) for (Player player : server.getOnlinePlayers())
{ {
if (player.getName().toLowerCase().contains(targetName) || player.getDisplayName().toLowerCase().contains(targetName) if ((player.getName().toLowerCase().contains(targetName) || player.getDisplayName().toLowerCase().contains(targetName)
|| player.getName().contains(targetName) || player.getDisplayName().contains(targetName)) || player.getName().contains(targetName) || player.getDisplayName().contains(targetName))
{ && player.isOp() && !plugin.al.isVanished(player.getName()))
if (player.isOp() && !plugin.al.isVanished(player.getName()))
{ {
matchedPlayerNames.add(player.getName()); matchedPlayerNames.add(player.getName());
player.setOp(false); player.setOp(false);
@ -43,7 +42,6 @@ public class Command_deop extends FreedomCommand
plugin.rm.updateDisplay(player); plugin.rm.updateDisplay(player);
} }
} }
}
if (!matchedPlayerNames.isEmpty()) if (!matchedPlayerNames.isEmpty())
{ {

View File

@ -251,9 +251,7 @@ public class Command_enchant extends FreedomCommand
return getEnchantments(item); return getEnchantments(item);
} }
} }
else if (args.length == 3) else if (args.length == 3 && args[0].equalsIgnoreCase("add"))
{
if (args[0].equals("add"))
{ {
Enchantment enchantment = Enchantment.getByName(args[1].toUpperCase()); Enchantment enchantment = Enchantment.getByName(args[1].toUpperCase());
if (enchantment != null) if (enchantment != null)
@ -268,7 +266,6 @@ public class Command_enchant extends FreedomCommand
} }
} }
} }
}
return Collections.emptyList(); return Collections.emptyList();
} }

View File

@ -22,19 +22,21 @@ public class DiscordToMinecraftListener extends ListenerAdapter
public void onMessageReceived(MessageReceivedEvent event) public void onMessageReceived(MessageReceivedEvent event)
{ {
String chat_channel_id = ConfigEntry.DISCORD_CHAT_CHANNEL_ID.getString(); String chat_channel_id = ConfigEntry.DISCORD_CHAT_CHANNEL_ID.getString();
if (event.getMember() != null && !chat_channel_id.isEmpty() && event.getChannel().getId().equals(chat_channel_id)) if (event.getMember() != null && !chat_channel_id.isEmpty()
{ && event.getChannel().getId().equals(chat_channel_id)
if (!event.getAuthor().getId().equals(Discord.bot.getSelfUser().getId())) && !event.getAuthor().getId().equals(Discord.bot.getSelfUser().getId()))
{ {
Member member = event.getMember(); Member member = event.getMember();
String tag = getDisplay(member); String tag = getDisplay(member);
StringBuilder message = new StringBuilder(ChatColor.DARK_GRAY + "[" + ChatColor.DARK_AQUA + "Discord" + ChatColor.DARK_GRAY + "]"); StringBuilder message = new StringBuilder(ChatColor.DARK_GRAY + "[" + ChatColor.DARK_AQUA + "Discord"
+ ChatColor.DARK_GRAY + "]");
Message msg = event.getMessage(); Message msg = event.getMessage();
if (tag != null) if (tag != null)
{ {
message.append(" ").append(tag); message.append(" ").append(tag);
} }
message.append(" ").append(ChatColor.RED).append(ChatColor.stripColor(member.getEffectiveName())).append(ChatColor.DARK_GRAY).append(":").append(ChatColor.RESET); message.append(" ").append(ChatColor.RED).append(ChatColor.stripColor(member.getEffectiveName()))
.append(ChatColor.DARK_GRAY).append(":").append(ChatColor.RESET);
ComponentBuilder builder = new ComponentBuilder(message.toString()); ComponentBuilder builder = new ComponentBuilder(message.toString());
if (!msg.getContentDisplay().isEmpty()) if (!msg.getContentDisplay().isEmpty())
{ {
@ -63,7 +65,6 @@ public class DiscordToMinecraftListener extends ListenerAdapter
FLog.info(message.toString()); FLog.info(message.toString());
} }
} }
}
public String getDisplay(Member member) public String getDisplay(Member member)
{ {