Removed redundant null checks and fixed a potential file separator issue

This commit is contained in:
MattBDev 2021-05-11 20:01:11 -04:00
parent 277046d5c9
commit 4c1d0bc9a6
3 changed files with 6 additions and 9 deletions

View File

@ -188,7 +188,7 @@ public class FaweAPI {
if (!file.getName().toLowerCase(Locale.ROOT).endsWith(".bd")) {
throw new IllegalArgumentException("Not a BD file!");
}
String[] path = file.getPath().split(File.separator);
String[] path = file.getPath().split(File.separatorChar=='\\' ? "\\\\" : File.separator);
if (path.length < 3) {
throw new IllegalArgumentException("Not in history directory!");
}

View File

@ -77,11 +77,9 @@ public class FastByteArrayOutputStream extends OutputStream {
// Check if we have a list of buffers
int pos = 0;
if (buffers != null) {
for (byte[] bytes : buffers) {
System.arraycopy(bytes, 0, data, pos, bytes.length);
pos += bytes.length;
}
for (byte[] bytes : buffers) {
System.arraycopy(bytes, 0, data, pos, bytes.length);
pos += bytes.length;
}
// write the internal buffer directly

View File

@ -59,12 +59,11 @@ public abstract class BlockBag {
}
fetchBlock(blockState);
} catch (OutOfBlocksException e) {
BlockState placed = blockState; // TODO BlockType.getBlockBagItem(id, data);
if (placed == null || placed.getBlockType().getMaterial().isAir()) {
if (blockState.getBlockType().getMaterial().isAir()) {
throw e; // TODO: check
}
fetchBlock(placed);
fetchBlock(blockState);
}
}