ParametricCallable.mayConsumeArguments() handles flags better.

This commit is contained in:
sk89q 2014-07-02 12:52:42 -07:00
parent 06c248e518
commit 765d987ae1

View File

@ -345,19 +345,23 @@ class ParametricCallable implements CommandCallable {
// - Before required parameters: Consume if there are 'left over' args
// - At the end: Always consumes
if (parameter.isOptional() && parameter.getFlag() == null) {
int numberFree = context.argsLength() - scoped.position();
for (int j = i; j < parameters.length; j++) {
if (parameters[j].isNonFlagConsumer() && !parameters[j].isOptional()) {
// We already checked if the consumed count was > -1
// when we created this object
numberFree -= parameters[j].getConsumedCount();
if (parameter.isOptional()) {
if (parameter.getFlag() != null) {
return !parameter.isValueFlag() || context.hasFlag(parameter.getFlag());
} else {
int numberFree = context.argsLength() - scoped.position();
for (int j = i; j < parameters.length; j++) {
if (parameters[j].isNonFlagConsumer() && !parameters[j].isOptional()) {
// We already checked if the consumed count was > -1
// when we created this object
numberFree -= parameters[j].getConsumedCount();
}
}
}
// Skip this optional parameter
if (numberFree < 1) {
return false;
// Skip this optional parameter
if (numberFree < 1) {
return false;
}
}
}