From 8bfbc55c7166f9616b2bc66adfeffc36cd8b33f6 Mon Sep 17 00:00:00 2001 From: Matthew Miller Date: Thu, 30 Aug 2018 16:42:50 +1000 Subject: [PATCH] Enable experimental //walls for non-cuboid regions. --- .../src/main/java/com/sk89q/worldedit/EditSession.java | 8 ++++---- .../src/main/java/com/sk89q/worldedit/WorldEdit.java | 4 ++-- .../java/com/sk89q/worldedit/command/RegionCommands.java | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java b/worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java index fdbbb8e3b..593f6ec91 100644 --- a/worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java +++ b/worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java @@ -847,7 +847,7 @@ public class EditSession implements Extent { * @return number of blocks affected * @throws MaxChangedBlocksException thrown if too many blocks are changed */ - public int makeCuboidFaces(Region region, BaseBlock block) throws MaxChangedBlocksException { + public int makeCuboidFaces(Region region, BlockStateHolder block) throws MaxChangedBlocksException { return makeCuboidFaces(region, new BlockPattern(block)); } @@ -899,7 +899,7 @@ public class EditSession implements Extent { * @return number of blocks affected * @throws MaxChangedBlocksException thrown if too many blocks are changed */ - public int makeCuboidWalls(Region region, BaseBlock block) throws MaxChangedBlocksException { + public int makeCuboidWalls(Region region, BlockStateHolder block) throws MaxChangedBlocksException { return makeCuboidWalls(region, new BlockPattern(block)); } @@ -964,7 +964,7 @@ public class EditSession implements Extent { * @return number of blocks affected * @throws MaxChangedBlocksException thrown if too many blocks are changed */ - public int overlayCuboidBlocks(Region region, BaseBlock block) throws MaxChangedBlocksException { + public int overlayCuboidBlocks(Region region, BlockStateHolder block) throws MaxChangedBlocksException { checkNotNull(block); return overlayCuboidBlocks(region, new BlockPattern(block)); @@ -1091,7 +1091,7 @@ public class EditSession implements Extent { * @return number of blocks moved * @throws MaxChangedBlocksException thrown if too many blocks are changed */ - public int moveCuboidRegion(Region region, Vector dir, int distance, boolean copyAir, BaseBlock replacement) throws MaxChangedBlocksException { + public int moveCuboidRegion(Region region, Vector dir, int distance, boolean copyAir, BlockStateHolder replacement) throws MaxChangedBlocksException { return moveRegion(region, dir, distance, copyAir, replacement); } diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/WorldEdit.java b/worldedit-core/src/main/java/com/sk89q/worldedit/WorldEdit.java index 5d6233f23..c25e5a2c0 100644 --- a/worldedit-core/src/main/java/com/sk89q/worldedit/WorldEdit.java +++ b/worldedit-core/src/main/java/com/sk89q/worldedit/WorldEdit.java @@ -24,7 +24,6 @@ import static com.sk89q.worldedit.event.platform.Interaction.OPEN; import com.google.common.collect.ImmutableList; import com.google.common.collect.Lists; -import com.sk89q.worldedit.world.block.BaseBlock; import com.sk89q.worldedit.blocks.BaseItem; import com.sk89q.worldedit.entity.Player; import com.sk89q.worldedit.event.platform.BlockInteractEvent; @@ -51,6 +50,7 @@ import com.sk89q.worldedit.util.io.file.FilenameException; import com.sk89q.worldedit.util.io.file.FilenameResolutionException; import com.sk89q.worldedit.util.io.file.InvalidFilenameException; import com.sk89q.worldedit.util.logging.WorldEditPrefixHandler; +import com.sk89q.worldedit.world.block.BlockStateHolder; import com.sk89q.worldedit.world.block.BlockType; import com.sk89q.worldedit.world.registry.BundledBlockData; import com.sk89q.worldedit.world.registry.BundledItemData; @@ -144,7 +144,7 @@ public class WorldEdit { } /** - * Get the block factory from which new {@link BaseBlock}s can be + * Get the block factory from which new {@link BlockStateHolder}s can be * constructed. * * @return the block factory diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/command/RegionCommands.java b/worldedit-core/src/main/java/com/sk89q/worldedit/command/RegionCommands.java index 5b5c17133..3b7efa781 100644 --- a/worldedit-core/src/main/java/com/sk89q/worldedit/command/RegionCommands.java +++ b/worldedit-core/src/main/java/com/sk89q/worldedit/command/RegionCommands.java @@ -220,7 +220,7 @@ public class RegionCommands { @CommandPermissions("worldedit.region.walls") @Logging(REGION) public void walls(Player player, EditSession editSession, @Selection Region region, Pattern pattern) throws WorldEditException { - int affected = editSession.makeCuboidWalls(region, pattern); + int affected = editSession.makeWalls(region, pattern); player.print(affected + " block(s) have been changed."); }