From 9fc2387f1160617dac7f091d6a6f36ca74408857 Mon Sep 17 00:00:00 2001 From: Aurora Date: Wed, 1 Jul 2020 14:54:11 +0200 Subject: [PATCH] Revert "start reimplementing entities" This reverts commit aac02ceea167a47ec8fd449c60a972af2bf67080. --- .../sk89q/worldedit/bukkit/BukkitEntity.java | 2 +- .../sk89q/worldedit/bukkit/BukkitWorld.java | 1 + .../object/clipboard/WorldCopyClipboard.java | 5 - .../java/com/sk89q/worldedit/EditSession.java | 18 ---- .../com/sk89q/worldedit/extent/Extent.java | 1 - .../extent/clipboard/BlockArrayClipboard.java | 8 -- .../function/operation/ForwardExtentCopy.java | 7 +- .../worldedit/util/io/file/ArchiveDir.java | 26 ++--- .../worldedit/util/io/file/SafeFiles.java | 98 +++++++++---------- .../com/sk89q/worldedit/world/NullWorld.java | 1 - 10 files changed, 67 insertions(+), 100 deletions(-) diff --git a/worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitEntity.java b/worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitEntity.java index be50815f3..d21ddcd4c 100644 --- a/worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitEntity.java +++ b/worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitEntity.java @@ -89,7 +89,7 @@ public class BukkitEntity implements Entity { @Override public com.sk89q.worldedit.world.entity.EntityType getType() { - return EntityTypes.get(type.getName().toLowerCase(Locale.ROOT)); + return EntityTypes.get(type.getName().toUpperCase(Locale.ROOT)); } @Override diff --git a/worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitWorld.java b/worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitWorld.java index 2fe53dd30..588071c34 100644 --- a/worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitWorld.java +++ b/worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitWorld.java @@ -99,6 +99,7 @@ public class BukkitWorld extends AbstractWorld { @Override public List getEntities(Region region) { World world = getWorld(); + List ents = world.getEntities(); List entities = new ArrayList<>(); for (Entity ent : ents) { diff --git a/worldedit-core/src/main/java/com/boydti/fawe/object/clipboard/WorldCopyClipboard.java b/worldedit-core/src/main/java/com/boydti/fawe/object/clipboard/WorldCopyClipboard.java index 7bce8a84a..054ecae3e 100644 --- a/worldedit-core/src/main/java/com/boydti/fawe/object/clipboard/WorldCopyClipboard.java +++ b/worldedit-core/src/main/java/com/boydti/fawe/object/clipboard/WorldCopyClipboard.java @@ -63,9 +63,4 @@ public class WorldCopyClipboard extends ReadOnlyClipboard { return hasBiomes; } - @Override - public List getEntities(Region region) { - return getExtent().getEntities(region); - } - } diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java b/worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java index 29caa5b9c..e3e38757c 100644 --- a/worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java +++ b/worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java @@ -46,8 +46,6 @@ import com.boydti.fawe.util.ExtentTraverser; import com.boydti.fawe.util.MaskTraverser; import com.boydti.fawe.util.MathMan; import com.boydti.fawe.util.TaskManager; -import com.sk89q.worldedit.entity.BaseEntity; -import com.sk89q.worldedit.entity.Entity; import com.sk89q.worldedit.entity.Player; import com.sk89q.worldedit.event.extent.EditSessionEvent; import com.sk89q.worldedit.extent.AbstractDelegateExtent; @@ -3056,20 +3054,4 @@ public class EditSession extends PassthroughExtent implements AutoCloseable { } return false; } - - @Override - public List getEntities(Region region) { - return world.getEntities(region); - } - - @Override - public List getEntities() { - System.out.println("editsession"); - return world.getEntities(); - } - - @Override - public Entity createEntity(Location location, BaseEntity entity) { - return world.createEntity(location, entity); - } } diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/extent/Extent.java b/worldedit-core/src/main/java/com/sk89q/worldedit/extent/Extent.java index 03731a1c8..b9c20c8f0 100644 --- a/worldedit-core/src/main/java/com/sk89q/worldedit/extent/Extent.java +++ b/worldedit-core/src/main/java/com/sk89q/worldedit/extent/Extent.java @@ -132,7 +132,6 @@ public interface Extent extends InputExtent, OutputExtent { * @return a list of entities */ default List getEntities() { - System.out.println("el"); return Collections.emptyList(); } diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/BlockArrayClipboard.java b/worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/BlockArrayClipboard.java index 559fbc6a6..9817dd235 100644 --- a/worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/BlockArrayClipboard.java +++ b/worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/BlockArrayClipboard.java @@ -195,19 +195,11 @@ public class BlockArrayClipboard implements Clipboard { @Override public List getEntities(Region region) { - System.out.println("blockarrayclipboard"); region = region.clone(); region.shift(BlockVector3.ZERO.subtract(origin)); return getParent().getEntities(region); } - @Override - public List getEntities() { - System.out.println("blockarrayall"); - return getParent().getEntities(); - } - - @Override @Nullable public Entity createEntity(Location location, BaseEntity entity) { diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/function/operation/ForwardExtentCopy.java b/worldedit-core/src/main/java/com/sk89q/worldedit/function/operation/ForwardExtentCopy.java index ca96008b6..cedfee026 100644 --- a/worldedit-core/src/main/java/com/sk89q/worldedit/function/operation/ForwardExtentCopy.java +++ b/worldedit-core/src/main/java/com/sk89q/worldedit/function/operation/ForwardExtentCopy.java @@ -397,7 +397,7 @@ public class ForwardExtentCopy implements Operation { Operations.completeBlindly(blockCopy); if (!entities.isEmpty()) { - ExtentEntityCopy entityCopy = new ExtentEntityCopy(from.toVector3(), finalDest, to.toVector3(), currentTransform); + ExtentEntityCopy entityCopy = new ExtentEntityCopy(from.toVector3(), destination, to.toVector3(), currentTransform); entityCopy.setRemoving(removingEntities); List entities2 = Lists.newArrayList(source.getEntities(region)); entities2.removeIf(entity -> { @@ -406,7 +406,6 @@ public class ForwardExtentCopy implements Operation { }); EntityVisitor entityVisitor = new EntityVisitor(entities.iterator(), entityCopy); Operations.completeBlindly(entityVisitor); - affectedEntities += entityVisitor.getAffected(); } if (transExt != null) { @@ -428,8 +427,8 @@ public class ForwardExtentCopy implements Operation { return ImmutableList.of( TranslatableComponent.of("worldedit.operation.affected.block", TextComponent.of(affectedBlocks)).color(TextColor.LIGHT_PURPLE), - //TranslatableComponent.of("worldedit.operation.affected.biome", - // TextComponent.of(affectedBiomeCols)).color(TextColor.LIGHT_PURPLE), + TranslatableComponent.of("worldedit.operation.affected.biome", + TextComponent.of(affectedBiomeCols)).color(TextColor.LIGHT_PURPLE), TranslatableComponent.of("worldedit.operation.affected.entity", TextComponent.of(affectedEntities)).color(TextColor.LIGHT_PURPLE) ); diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/util/io/file/ArchiveDir.java b/worldedit-core/src/main/java/com/sk89q/worldedit/util/io/file/ArchiveDir.java index 32619f4fe..b0e48502f 100644 --- a/worldedit-core/src/main/java/com/sk89q/worldedit/util/io/file/ArchiveDir.java +++ b/worldedit-core/src/main/java/com/sk89q/worldedit/util/io/file/ArchiveDir.java @@ -18,16 +18,16 @@ */ package com.sk89q.worldedit.util.io.file; - -import java.io.Closeable; -import java.nio.file.Path; - -/** - * Represents an archive opened as a directory. This must be closed after work on the Path is - * done. - */ -public interface ArchiveDir extends Closeable { - - Path getPath(); - -} + +import java.io.Closeable; +import java.nio.file.Path; + +/** + * Represents an archive opened as a directory. This must be closed after work on the Path is + * done. + */ +public interface ArchiveDir extends Closeable { + + Path getPath(); + +} diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/util/io/file/SafeFiles.java b/worldedit-core/src/main/java/com/sk89q/worldedit/util/io/file/SafeFiles.java index 5a8363578..e790f0d30 100644 --- a/worldedit-core/src/main/java/com/sk89q/worldedit/util/io/file/SafeFiles.java +++ b/worldedit-core/src/main/java/com/sk89q/worldedit/util/io/file/SafeFiles.java @@ -18,52 +18,52 @@ */ package com.sk89q.worldedit.util.io.file; - -import java.io.IOException; -import java.nio.file.Files; -import java.nio.file.Path; -import java.util.List; -import java.util.stream.Collectors; -import java.util.stream.Stream; - -public class SafeFiles { - - /** - * A version of {@link Files#list(Path)} that won't leak resources. - * - *

- * Instead, it immediately consumes the entire listing into a {@link List} and - * calls {@link List#stream()}. - *

- * - * @param dir the directory to list - * @return an I/O-resource-free stream of the files in the directory - * @throws IOException if an I/O error occurs - */ - public static Stream noLeakFileList(Path dir) throws IOException { - try (Stream stream = Files.list(dir)) { - return stream.collect(Collectors.toList()).stream(); - } - } - - /** - * {@link Path#getFileName()} includes a slash sometimes for some reason. - * This will get rid of it. - * - * @param path the path to get the file name for - * @return the file name of the given path - */ - public static String canonicalFileName(Path path) { - return dropSlash(path.getFileName().toString()); - } - - private static String dropSlash(String name) { - if (name.isEmpty() || name.codePointBefore(name.length()) != '/') { - return name; - } - return name.substring(0, name.length() - 1); - } - - private SafeFiles() { - } -} + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.List; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +public class SafeFiles { + + /** + * A version of {@link Files#list(Path)} that won't leak resources. + * + *

+ * Instead, it immediately consumes the entire listing into a {@link List} and + * calls {@link List#stream()}. + *

+ * + * @param dir the directory to list + * @return an I/O-resource-free stream of the files in the directory + * @throws IOException if an I/O error occurs + */ + public static Stream noLeakFileList(Path dir) throws IOException { + try (Stream stream = Files.list(dir)) { + return stream.collect(Collectors.toList()).stream(); + } + } + + /** + * {@link Path#getFileName()} includes a slash sometimes for some reason. + * This will get rid of it. + * + * @param path the path to get the file name for + * @return the file name of the given path + */ + public static String canonicalFileName(Path path) { + return dropSlash(path.getFileName().toString()); + } + + private static String dropSlash(String name) { + if (name.isEmpty() || name.codePointBefore(name.length()) != '/') { + return name; + } + return name.substring(0, name.length() - 1); + } + + private SafeFiles() { + } +} diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/world/NullWorld.java b/worldedit-core/src/main/java/com/sk89q/worldedit/world/NullWorld.java index 81e3c9d7a..f3d6dd18a 100644 --- a/worldedit-core/src/main/java/com/sk89q/worldedit/world/NullWorld.java +++ b/worldedit-core/src/main/java/com/sk89q/worldedit/world/NullWorld.java @@ -192,7 +192,6 @@ public class NullWorld extends AbstractWorld { @Override public List getEntities(Region region) { - System.out.println("nullworld"); return Collections.emptyList(); }