Plexus/Plex-FAWE
1
0
Fork 0
mirror of https://github.com/plexusorg/Plex-FAWE.git synced 2024-12-23 09:47:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Speed up the BlockState hashCode method by caching (As it's Immutable). Allows some better optimisations in the future by using them as map keys

Browse Source
This commit is contained in:
Matthew Miller 2019-02-16 12:46:10 +10:00
parent de9d202681
commit d6bc85ccbe
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
worldedit-core/src/main/java/com/sk89q/worldedit/world/block/BlockState.java
View File

@ -146,7 +146,7 @@ public class BlockState implements BlockStateHolder<BlockState> {
@Override @Override
public boolean equalsFuzzy(BlockStateHolder<?> o) { public boolean equalsFuzzy(BlockStateHolder<?> o) {
if (this == o) { if (this == o) {
// Added a reference equality check for // Added a reference equality check for speediness
return true; return true;
} }
if (!getBlockType().equals(o.getBlockType())) { if (!getBlockType().equals(o.getBlockType())) {
@ -223,8 +223,13 @@ public class BlockState implements BlockStateHolder<BlockState> {
return equalsFuzzy((BlockState) obj); return equalsFuzzy((BlockState) obj);
} }
private Integer hashCodeCache = null;
@Override @Override
public int hashCode() { public int hashCode() {
return Objects.hash(blockType, values); if (hashCodeCache == null) {
hashCodeCache = Objects.hash(blockType, values);
}
return hashCodeCache;
} }
} }