Fix some horrendous code where methods supposed to return a boolean only ever return true (#1718)

This commit is contained in:
Jordan
2022-04-24 17:03:40 +01:00
committed by GitHub
parent 82ba96bf71
commit e294245ec4
2 changed files with 18 additions and 24 deletions

View File

@@ -70,56 +70,56 @@ public class LocationMaskedPlayerWrapper extends AsyncPlayer {
@Override
public boolean ascendLevel() {
if (allowTeleport) {
super.ascendLevel();
if (allowTeleport && super.ascendLevel()) {
update();
return true;
}
return true;
return false;
}
@Override
public boolean descendLevel() {
if (allowTeleport) {
super.descendLevel();
if (allowTeleport && super.descendLevel()) {
update();
return true;
}
return true;
return false;
}
@Override
public boolean ascendToCeiling(int clearance) {
if (allowTeleport) {
super.ascendToCeiling(clearance);
if (allowTeleport && super.ascendToCeiling(clearance)) {
update();
return true;
}
return true;
return false;
}
@Override
public boolean ascendToCeiling(int clearance, boolean alwaysGlass) {
if (allowTeleport) {
super.ascendToCeiling(clearance, alwaysGlass);
if (allowTeleport && super.ascendToCeiling(clearance, alwaysGlass)) {
update();
return true;
}
return true;
return false;
}
@Override
public boolean ascendUpwards(int distance) {
if (allowTeleport) {
super.ascendUpwards(distance);
if (allowTeleport && super.ascendUpwards(distance)) {
update();
return true;
}
return true;
return false;
}
@Override
public boolean ascendUpwards(int distance, boolean alwaysGlass) {
if (allowTeleport) {
super.ascendUpwards(distance, alwaysGlass);
if (allowTeleport && super.ascendUpwards(distance, alwaysGlass)) {
update();
return true;
}
return true;
return false;
}
@Override