Code clean up, add preconditions, and correct Javadocs.

This commit is contained in:
sk89q
2014-07-26 00:29:12 -07:00
parent 70bca47be7
commit e95eeefa2b
132 changed files with 857 additions and 651 deletions

View File

@ -19,6 +19,13 @@
package com.sk89q.worldedit.regions;
import com.sk89q.worldedit.LocalWorld;
import com.sk89q.worldedit.Vector;
import com.sk89q.worldedit.regions.polyhedron.Edge;
import com.sk89q.worldedit.regions.polyhedron.Triangle;
import com.sk89q.worldedit.world.World;
import javax.annotation.Nullable;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Iterator;
@ -26,13 +33,10 @@ import java.util.LinkedHashSet;
import java.util.List;
import java.util.Set;
import com.sk89q.worldedit.LocalWorld;
import com.sk89q.worldedit.Vector;
import com.sk89q.worldedit.regions.polyhedron.Edge;
import com.sk89q.worldedit.regions.polyhedron.Triangle;
import com.sk89q.worldedit.world.World;
import static com.google.common.base.Preconditions.checkNotNull;
public class ConvexPolyhedralRegion extends AbstractRegion {
/**
* Vertices that are contained in the convex hull.
*/
@ -71,12 +75,15 @@ public class ConvexPolyhedralRegion extends AbstractRegion {
/**
* Constructs an empty mesh, containing no vertices or triangles.
*
* @param world
* @param world the world
*/
public ConvexPolyhedralRegion(World world) {
public ConvexPolyhedralRegion(@Nullable World world) {
super(world);
}
/**
* @deprecated cast {@code world} to {@link World}
*/
@Deprecated
public ConvexPolyhedralRegion(LocalWorld world) {
super(world);
@ -116,10 +123,12 @@ public class ConvexPolyhedralRegion extends AbstractRegion {
/**
* Add a vertex to the region.
*
* @param vertex
* @param vertex the vertex
* @return true, if something changed.
*/
public boolean addVertex(Vector vertex) {
checkNotNull(vertex);
lastTriangle = null; // Probably not necessary
if (vertices.contains(vertex)) {