Plexus/Plex
1
0
Fork 0
mirror of https://github.com/plexusorg/Plex.git synced 2024-12-22 17:17:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix whitespace bypassing command blocker

Browse Source
This commit is contained in:
Allink 2022-07-24 03:44:18 +01:00
parent 5f64e02cae
commit b26e489e83
No known key found for this signature in database
GPG Key ID: 6C2F7CE6E0519E14
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
server/src/main/java/dev/plex/listener/impl/CommandListener.java
View File

@ -38,10 +38,11 @@ public class CommandListener extends PlexListener
@EventHandler(priority = EventPriority.HIGHEST) @EventHandler(priority = EventPriority.HIGHEST)
public void onCommandBlocking(PlayerCommandPreprocessEvent event) public void onCommandBlocking(PlayerCommandPreprocessEvent event)
{ {
String command = "/" + event.getMessage().replaceFirst("/", "").trim();
Player player = event.getPlayer(); Player player = event.getPlayer();
PlexPlayer plexPlayer = DataUtils.getPlayer(player.getUniqueId()); PlexPlayer plexPlayer = DataUtils.getPlayer(player.getUniqueId());
String commandName = StringUtils.normalizeSpace(event.getMessage()).split(" ")[0].replaceFirst("/", ""); String commandName = StringUtils.normalizeSpace(command).split(" ")[0].replaceFirst("/", "");
String arguments = StringUtils.normalizeSpace(StringUtils.normalizeSpace(event.getMessage()).replace(event.getMessage().split(" ")[0], "")); String arguments = StringUtils.normalizeSpace(StringUtils.normalizeSpace(command).replace(command.split(" ")[0], ""));
PlexLog.debug("Checking Command: {0} with args {1}", commandName, arguments); PlexLog.debug("Checking Command: {0} with args {1}", commandName, arguments);
AtomicReference<BlockedCommand> cmdRef = new AtomicReference<>(); AtomicReference<BlockedCommand> cmdRef = new AtomicReference<>();
PlexLog.debug("Blocked Commands List: " + CommandBlockerService.getBLOCKED_COMMANDS().size()); PlexLog.debug("Blocked Commands List: " + CommandBlockerService.getBLOCKED_COMMANDS().size());
@ -49,7 +50,7 @@ public class CommandListener extends PlexListener
{ {
boolean matches = true; boolean matches = true;
String[] args = blockedCommand.getCommand().split(" "); String[] args = blockedCommand.getCommand().split(" ");
String[] cmdArgs = event.getMessage().replaceFirst("/", "").split(" "); String[] cmdArgs = command.replaceFirst("/", "").split(" ");
for (int i = 0; i < args.length; i++) for (int i = 0; i < args.length; i++)
{ {
if (i + 1 > cmdArgs.length) if (i + 1 > cmdArgs.length)
@ -87,7 +88,7 @@ public class CommandListener extends PlexListener
if (blockedCommand.getRegex() != null) if (blockedCommand.getRegex() != null)
{ {
Pattern pattern = Pattern.compile(blockedCommand.getRegex(), Pattern.CASE_INSENSITIVE); Pattern pattern = Pattern.compile(blockedCommand.getRegex(), Pattern.CASE_INSENSITIVE);
Matcher matcher = pattern.matcher(event.getMessage().replaceFirst("/", "")); Matcher matcher = pattern.matcher(command.replaceFirst("/", ""));
if (matcher.find()) if (matcher.find())
{ {
PlexLog.debug("Player attempted to use a blocked regex"); PlexLog.debug("Player attempted to use a blocked regex");