Revert "Add BroadcastEvent"

This reverts commit aab5083f78.

server/build.gradle.kts

@@ -57,10 +57,6 @@ paper {
             required = false
             load = PaperPluginDescription.RelativeLoadOrder.BEFORE
         }
-        register("DiscordSRV") {
-            required = false
-            load = PaperPluginDescription.RelativeLoadOrder.AFTER
-        }
         register("Essentials") {
             required = false
             load = PaperPluginDescription.RelativeLoadOrder.BEFORE

server/src/main/java/dev/plex/PlexLibraryManager.java

@@ -33,11 +33,6 @@ public class PlexLibraryManager implements PluginLoader
             resolver.addDependency(new Dependency(new DefaultArtifact("org.eclipse.jetty:jetty-servlet:11.0.19"), null));
             resolver.addDependency(new Dependency(new DefaultArtifact("org.eclipse.jetty:jetty-proxy:11.0.19"), null));
         }
-        if (new File("plugins/Plex/modules/Module-DiscordSRV.jar").isFile())
-        {
-            resolver.addRepository(new RemoteRepository.Builder("discordsrv", "default", "https://nexus.scarsz.me/content/groups/public/").build());
-            resolver.addDependency(new Dependency(new DefaultArtifact("com.discordsrv:discordsrv:1.27.0"), null));
-        }
         classpathBuilder.addLibrary(resolver);
     }
 

server/src/main/java/dev/plex/command/impl/SetLoginMessageCMD.java

@@ -11,6 +11,7 @@ import dev.plex.player.PlexPlayer;
 import dev.plex.util.PlexLog;
 import dev.plex.util.PlexUtils;
 import net.kyori.adventure.text.Component;
+import net.kyori.adventure.text.minimessage.MiniMessage;
 import org.apache.commons.lang3.StringUtils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
@@ -56,20 +57,18 @@ public class SetLoginMessageCMD extends PlexCommand
                 validateMessage(message);
                 plexPlayer.setLoginMessage(message);
                 return messageComponent("setOtherPlayersLoginMessage", plexPlayer.getName(),
-                        message.replace("%player%", plexPlayer.getName()));
+                        MiniMessage.miniMessage().serialize(PlexUtils.stringToComponent(message.replace("%player%", plexPlayer.getName()))));
             }
             if (isConsole(sender))
             {
                 return messageComponent("noPermissionConsole");
             }
             PlexPlayer plexPlayer = plugin.getPlayerCache().getPlexPlayer(playerSender.getUniqueId());
-            String message = StringUtils.join(args, " ", 0, args.length);
-            message = message.replace(plexPlayer.getName(), "%player%");
-            message = PlexUtils.legacyToMiniString(message);
+            String message = StringUtils.join(args, " ", 0, args.length)
+                    .replace(plexPlayer.getName(), "%player%");
             validateMessage(message);
             plexPlayer.setLoginMessage(message);
-            return messageComponent("setOwnLoginMessage",
-                    message.replace("%player%", plexPlayer.getName()));
+            return messageComponent("setOwnLoginMessage", PlexUtils.stringToComponent(message.replace("%player%", plexPlayer.getName())));
         }
         return null;
     }

server/src/main/java/dev/plex/command/impl/TagCMD.java

@@ -50,16 +50,15 @@ public class TagCMD extends PlexCommand
             {
                 return usage("/tag set <prefix>");
             }
-            String prefix = PlexUtils.legacyToMiniString(StringUtils.join(args, " ", 1, args.length));
 
-            Component convertedComponent = SafeMiniMessage.mmDeserializeWithoutEvents(prefix);
+            Component convertedComponent = PlexUtils.stringToComponent(StringUtils.join(args, " ", 1, args.length));
 
             if (PlainTextComponentSerializer.plainText().serialize(convertedComponent).length() > plugin.config.getInt("chat.max-tag-length", 16))
             {
                 return messageComponent("maximumPrefixLength", plugin.config.getInt("chat.max-tag-length", 16));
             }
 
-            player.setPrefix(prefix);
+            player.setPrefix(MiniMessage.miniMessage().serialize(convertedComponent));
             DataUtils.update(player);
             return messageComponent("prefixSetTo", MiniMessage.miniMessage().serialize(convertedComponent));
         }

server/src/main/java/dev/plex/event/BroadcastEvent.java

@@ -1,30 +0,0 @@
-package dev.plex.event;
-
-import lombok.Data;
-import lombok.EqualsAndHashCode;
-import net.kyori.adventure.text.Component;
-import org.bukkit.event.Event;
-import org.bukkit.event.HandlerList;
-import org.jetbrains.annotations.NotNull;
-
-@EqualsAndHashCode(callSuper = false)
-@Data
-public class BroadcastEvent extends Event
-{
-    private static final HandlerList handlers = new HandlerList();
-
-    private final Component message;
-
-    private final String string;
-
-    public static HandlerList getHandlerList()
-    {
-        return handlers;
-    }
-
-    @Override
-    public @NotNull HandlerList getHandlers()
-    {
-        return handlers;
-    }
-}

server/src/main/java/dev/plex/hook/VaultHook.java

@@ -82,8 +82,8 @@ public class VaultHook
         if (vaultPrefix == null || vaultPrefix.isEmpty()) {
             return Component.empty();
         }
-        PlexLog.debug("prefix: {0}", PlexUtils.legacyToMiniString(vaultPrefix).replace("<", "\\<"));
-        return SafeMiniMessage.mmDeserializeWithoutEvents(PlexUtils.legacyToMiniString(vaultPrefix));
+        PlexLog.debug("prefix: {0}", SafeMiniMessage.mmSerializeWithoutEvents(PlexUtils.stringToComponent(vaultPrefix)).replace("<", "\\<"));
+        return PlexUtils.stringToComponent(vaultPrefix);
     }
 
     public static Permission getPermission()

server/src/main/java/dev/plex/listener/impl/ChatListener.java

@@ -12,7 +12,6 @@ import io.papermc.paper.chat.ChatRenderer;
 import io.papermc.paper.event.player.AsyncChatEvent;
 import net.kyori.adventure.audience.Audience;
 import net.kyori.adventure.text.Component;
-import net.kyori.adventure.text.TextComponent;
 import net.kyori.adventure.text.TextReplacementConfig;
 import net.kyori.adventure.text.event.ClickEvent;
 import net.kyori.adventure.text.format.NamedTextColor;
@@ -47,7 +46,7 @@ public class ChatListener extends PlexListener
         {
             String prefix = PlexUtils.mmSerialize(VaultHook.getPrefix(event.getPlayer())); // Don't use PlexPlayer#getPrefix because that returns their custom set prefix and not their group's
             MessageUtil.sendStaffChat(event.getPlayer(), event.message(), PlexUtils.adminChat(event.getPlayer().getName(), prefix, SafeMiniMessage.mmSerialize(event.message())).toArray(UUID[]::new));
-            plugin.getServer().getConsoleSender().sendMessage(PlexUtils.messageComponent("adminChatFormat", event.getPlayer().getName(), prefix, PlexUtils.legacyToMiniString(SafeMiniMessage.mmSerializeWithoutEvents(event.message()))).replaceText(URL_REPLACEMENT_CONFIG));
+            plugin.getServer().getConsoleSender().sendMessage(PlexUtils.messageComponent("adminChatFormat", event.getPlayer().getName(), prefix, SafeMiniMessage.mmSerialize(event.message().replaceText(URL_REPLACEMENT_CONFIG))));
             event.setCancelled(true);
             return;
         }
@@ -105,7 +104,7 @@ public class ChatListener extends PlexListener
 
     private static void defaultChatProcessing(AsyncChatEvent event, PlexPlayer plexPlayer)
     {
-        String text = PlexUtils.legacyToMiniString(PlexUtils.getTextFromComponent(event.message()));
-        event.message(SafeMiniMessage.mmDeserializeWithoutEvents(text));
+        String text = PlexUtils.getTextFromComponent(event.message());
+        event.message(PlexUtils.stringToComponent(text));
     }
 }

server/src/main/java/dev/plex/listener/impl/PlayerListener.java

@@ -65,7 +65,7 @@ public class PlayerListener<T> extends PlexListener
         String loginMessage = PlayerMeta.getLoginMessage(plexPlayer);
         if (!loginMessage.isEmpty())
         {
-            PlexUtils.broadcast(loginMessage);
+            PlexUtils.broadcast(PlexUtils.stringToComponent(loginMessage));
         }
 
         plexPlayer.loadNotes();

server/src/main/java/dev/plex/listener/impl/SignListener.java

@@ -1,22 +0,0 @@
-package dev.plex.listener.impl;
-
-import dev.plex.listener.PlexListener;
-import dev.plex.util.PlexUtils;
-import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer;
-import org.bukkit.event.EventHandler;
-import org.bukkit.event.EventPriority;
-import org.bukkit.event.block.SignChangeEvent;
-
-public class SignListener extends PlexListener
-{
-    private static final LegacyComponentSerializer LEGACY_COMPONENT_SERIALIZER = LegacyComponentSerializer.legacyAmpersand();
-
-    @EventHandler(priority = EventPriority.LOW)
-    public void onSignEdit(SignChangeEvent event)
-    {
-        for (int i = 0; i < event.lines().size(); i++)
-        {
-            event.line(i, LEGACY_COMPONENT_SERIALIZER.deserialize(PlexUtils.getTextFromComponent(event.line(i))));
-        }
-    }
-}

server/src/main/java/dev/plex/util/PlexUtils.java

@@ -4,13 +4,15 @@ import com.google.common.base.CharMatcher;
 import com.google.common.collect.Lists;
 import dev.plex.Plex;
 import dev.plex.PlexBase;
-import dev.plex.event.BroadcastEvent;
 import dev.plex.listener.impl.ChatListener;
 import dev.plex.storage.StorageType;
+import dev.plex.util.minimessage.SafeMiniMessage;
 import net.kyori.adventure.text.Component;
 import net.kyori.adventure.text.TextComponent;
+import net.kyori.adventure.text.format.TextDecoration;
 import net.kyori.adventure.text.minimessage.MiniMessage;
 import net.kyori.adventure.text.minimessage.tag.resolver.TagResolver;
+import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer;
 import net.kyori.adventure.text.serializer.plain.PlainTextComponentSerializer;
 import org.bukkit.Bukkit;
 import org.bukkit.Location;
@@ -29,6 +31,7 @@ import java.util.Arrays;
 import java.util.List;
 import java.util.Stack;
 import java.util.UUID;
+import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 
 public class PlexUtils implements PlexBase
@@ -44,6 +47,8 @@ public class PlexUtils implements PlexBase
                     "a52f1f08-a398-400a-bca4-2b74b81feae6" // Allink
             );
 
+    private static final Pattern LEGACY_FORMATTING_PATTERN = Pattern.compile(".*(?i)(([§&])((#[a-f0-9]{3,6})|([0-9a-fklmnor]))).*");
+
     public static <T> T addToArrayList(List<T> list, T object)
     {
         list.add(object);
@@ -146,6 +151,17 @@ public class PlexUtils implements PlexBase
         return component;
     }
 
+    public static Component stringToComponent(String input)
+    {
+        input = cleanString(input);
+
+        return LEGACY_FORMATTING_PATTERN.matcher(input).find() ?
+                LegacyComponentSerializer.legacyAmpersand().deserialize(input.replaceAll("([§&]+)(k+)", "") // Ugly hack, but it tries to prevent &k and any attempts to bypass it.
+                        ).decoration(TextDecoration.OBFUSCATED, TextDecoration.State.FALSE) :
+                SafeMiniMessage.mmDeserializeWithoutEvents(input);
+    }
+
+    @Deprecated
     public static String legacyToMiniString(String input)
     {
         return cleanString(input.replace("&a", "<green>")
@@ -275,13 +291,11 @@ public class PlexUtils implements PlexBase
     public static void broadcast(String s)
     {
         Bukkit.broadcast(MINI_MESSAGE.deserialize(s));
-        Bukkit.getServer().getPluginManager().callEvent(new BroadcastEvent(null, s));
     }
 
     public static void broadcast(Component component)
     {
         Bukkit.broadcast(component);
-        Bukkit.getServer().getPluginManager().callEvent(new BroadcastEvent(component, null));
     }
 
     public static void broadcastToAdmins(Component component, String permission)