Clean up other compiler warnings

This commit is contained in:
Kenzie Togami 2018-12-26 16:50:24 -08:00 committed by IronApollo
parent 94ebb81e92
commit 4b5b7b8003
4 changed files with 20 additions and 33 deletions

View File

@ -348,41 +348,27 @@ public class WorldEditPlugin extends JavaPlugin //implements TabCompleter
protected void createDefaultConfiguration(String name) {
File actual = new File(getDataFolder(), name);
if (!actual.exists()) {
InputStream input = null;
try {
JarFile file = new JarFile(getFile());
try (JarFile file = new JarFile(getFile())) {
ZipEntry copy = file.getEntry("defaults/" + name);
if (copy == null) throw new FileNotFoundException();
input = file.getInputStream(copy);
copyDefaultConfig(file.getInputStream(copy), actual, name);
} catch (IOException e) {
getLogger().severe("Unable to read default configuration: " + name);
}
if (input != null) {
FileOutputStream output = null;
}
}
try {
output = new FileOutputStream(actual);
byte[] buf = new byte[8192];
int length;
while ((length = input.read(buf)) > 0) {
output.write(buf, 0, length);
}
getLogger().info("Default configuration file written: " + name);
} catch (IOException e) {
getLogger().log(Level.WARNING, "Failed to write default config file", e);
} finally {
try {
input.close();
} catch (IOException ignored) {}
try {
if (output != null) {
output.close();
}
} catch (IOException ignored) {}
}
private void copyDefaultConfig(InputStream input, File actual, String name) {
try (FileOutputStream output = new FileOutputStream(actual)) {
byte[] buf = new byte[8192];
int length;
while ((length = input.read(buf)) > 0) {
output.write(buf, 0, length);
}
getLogger().info("Default configuration file written: " + name);
} catch (IOException e) {
getLogger().log(Level.WARNING, "Failed to write default config file", e);
}
}

View File

@ -97,7 +97,7 @@ public class ListTagBuilder {
*
* @return a new builder
*/
public static <T extends Tag> ListTagBuilder createWith(T ... entries) {
public static ListTagBuilder createWith(Tag... entries) {
checkNotNull(entries);
if (entries.length == 0) {

View File

@ -85,7 +85,7 @@ public final class FileDialogUtil {
if (index == -1 || index == path.length() - 1) {
return false;
} else {
return exts.contains(path.indexOf(index + 1));
return exts.contains(path.substring(index + 1));
}
}

View File

@ -133,9 +133,10 @@ public class Snapshot implements Comparable<Snapshot> {
public boolean containsWorld(String worldname) {
try {
if (file.getName().toLowerCase().endsWith(".zip")) {
ZipFile entry = new ZipFile(file);
return (entry.getEntry(worldname) != null
|| entry.getEntry(worldname + "/level.dat") != null);
try (ZipFile entry = new ZipFile(file)) {
return (entry.getEntry(worldname) != null
|| entry.getEntry(worldname + "/level.dat") != null);
}
} else if (file.getName().toLowerCase().endsWith(".tar.bz2")
|| file.getName().toLowerCase().endsWith(".tar.gz")
|| file.getName().toLowerCase().endsWith(".tar")) {