Plexus/Plex-FAWE
1
0
Fork 0
mirror of https://github.com/plexusorg/Plex-FAWE.git synced 2024-12-23 01:37:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix region contain method

Browse Source 
The region contain method was broken.
A lot of subsquent issues are caused by this bug.
E.g. in a selection the entities in the last blocks at the positive-axis border are not selected.

Max block gives the impression of an exclusive point; however it is inclusive!
A position that is anywhere between of a 1x1x1 region, would return false in the old implementation.

By simply adding a one this should solve the problem.

Greetings
This commit is contained in:
Michael 2016-09-13 09:26:23 +02:00 committed by GitHub
parent 34c31dc020
commit 5de4cfced2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
worldedit-core/src/main/java/com/sk89q/worldedit/regions/CuboidRegion.java
View File

@ -336,9 +336,9 @@ public class CuboidRegion extends AbstractRegion implements FlatRegion {
Vector min = getMinimumPoint(); Vector min = getMinimumPoint();
Vector max = getMaximumPoint(); Vector max = getMaximumPoint();
return x >= min.getBlockX() && x <= max.getBlockX() return x >= min.getBlockX() && x < max.getBlockX() + 1
&& y >= min.getBlockY() && y <= max.getBlockY() && y >= min.getBlockY() && y < max.getBlockY() + 1
&& z >= min.getBlockZ() && z <= max.getBlockZ(); && z >= min.getBlockZ() && z < max.getBlockZ() + 1;
} }
@Override @Override